基于全量源码审计(electron/ 70+ 文件、src/ 45+ 文件完整读取)的 四阶段迭代,修复 1 项安全缺陷、8 项功能缺陷、依赖与文档系统性脱节。 【P0 安全与数据正确性】 - S-1 数据导出泄露明文密钥:data:export 全量导出直接透传 configService.getAll()(敏感 key 解密返回),导出文件含明文 API Key。 新增 sanitizeExportConfig(shared.ts)逐 key 脱敏 + 5 项回归测试 - F-3 session_summaries 无级联删除:删会话后摘要永久残留。建表语句补 FOREIGN KEY ON DELETE CASCADE + 迁移 8 重建存量表(幂等检测)+ 2 项测试 - F-4 macOS activate 重建窗口后确认弹框失效:窗口创建收敛为 createMainWindow 单一入口(beforeLoad 补 setMainWindow/IPC 注册),TrayManager 补 rebindWindow,app:selectFolder 改 event.sender 动态解析窗口 【P1 死代码激活与功能补全】 - F-1 会话右键菜单挂载:ContextMenu session 分支(重命名/置顶/归档/ 导出/删除)约 200 行此前无任何触发点,Sidebar SessionItem 挂载 onContextMenu;置顶/归档 label 随状态切换显示 - F-2 归档会话不可找回:Sidebar 新增「已归档」折叠面板(恢复入口), 归档功能形成完整闭环 - F-7 Provider 白名单校验:createAdapter/buildFallbackAdapter 未知 provider 显式拒绝(此前静默落入 DeepSeekAdapter 以空配置失败) - F-8 死配置治理:接通 5 项(llm.temperature/llm.maxTokens 注入引擎、 security.promptInjectionDefense 控制 SecurityScanHook+消息检测、 logging.auditEnabled 控制 AuditLogHook、logging.traceEnabled 控制 SessionRecorder,均 fail-secure 仅显式 false 关闭);删除 4 项 无消费者配置(requireWriteConfirmation/maxFileWriteSizeKB/fontSize/ animationMode) 【P2 依赖治理与 UX 修缮】 - D-1 移除僵尸依赖 electron-store/zod/rehype-raw(源码零引用, 共裁 24 包);README 技术栈表同步删除虚假宣称 - metona-toast 升级 0.2.1 → 0.5.0(API 全兼容:107 种图标类型、 配置项超集,default/configure/use 接口不变) - F-5 工作空间手输路径实时落库中间态:改 pendingPath 草稿 + 显式 「校验」按钮(选择文件夹与手输共用 validatePath 流程) - F-6 确认弹框超时滞留:倒计时归零时主动 refreshPending(后端超时 已删条目,拉取后弹框自然消解) - D-3 ChatInput accept 移除 .pdf(分类器不识别,误导性入口); Onboarding 切换 Provider 自动填充默认 URL(与 LLMSettings 一致) 【P3 文档口径收敛】 - README:工具数 30+→28、版本 0.6.0、测试数 252、配置表补 F-8 接通项 - built-in/index.ts 计数注释 30→28 - docs/网络工具 v2 存储键名统一为点号口径(searxng.enabled) - docs/完整设计指南修正 db.handlers.ts 失效路径引用为 data.ts 【验证】 - lint 0 error / 0 warning - typecheck 双工程(node+web)0 错误 - test:electron 24 文件 252 用例全通过(+7 新增:导出脱敏 ×5、 级联删除 ×2) - electron-vite build 成功(metona-toast 0.5.0 chunk 正常) - 系统 Node 模式 npm test 225 通过 + 27 ABI skip(符合预期)
358 lines
10 KiB
TypeScript
358 lines
10 KiB
TypeScript
/**
|
||
* Session Recorder — 会话录制器(TRACE 层)
|
||
*
|
||
* 负责将完整的会话执行轨迹写入 session_*.jsonl 文件。
|
||
* 每行一条 JSON 事件,支持事后回放和分析。
|
||
*
|
||
* P1-6 重构:
|
||
* 1. 多会话支持——每个会话独立的状态(文件路径/seq),并发会话互不串扰
|
||
* (原实现单会话状态,第二个会话 startRecording 会覆盖第一个的录制目标)
|
||
* 2. 事件签名统一携带 sessionId 参数,与 README 宣称的 9 种事件对齐:
|
||
* session_start, context_built, iteration_start, llm_request,
|
||
* llm_response, tool_call, tool_result, iteration_end, session_end
|
||
*
|
||
* 日志格式:SSE-like JSON Lines
|
||
*
|
||
* @see docs/MetonaAI-Desktop 架构与交互设计.html — 全链路透明可追踪
|
||
* @see docs/生产级通用 AI Agent 智能体桌面应用:完整设计与构建指南.html — 第十一章
|
||
*/
|
||
|
||
import { join } from 'path';
|
||
import { appendFileSync, existsSync, mkdirSync, promises } from 'fs';
|
||
import log from 'electron-log';
|
||
|
||
// ===== 事件类型 =====
|
||
|
||
export type TraceEventType =
|
||
| 'session_start'
|
||
| 'context_built'
|
||
| 'iteration_start'
|
||
| 'llm_request'
|
||
| 'llm_response'
|
||
| 'tool_call'
|
||
| 'tool_result'
|
||
| 'iteration_end'
|
||
| 'session_end';
|
||
|
||
export interface TraceEvent {
|
||
seq: number;
|
||
ts: string;
|
||
event: TraceEventType;
|
||
sessionId: string;
|
||
[key: string]: unknown;
|
||
}
|
||
|
||
/** 单个会话的录制状态 */
|
||
interface SessionRecordState {
|
||
filePath: string;
|
||
seq: number;
|
||
buffer: string[];
|
||
flushTimer: NodeJS.Timeout | null;
|
||
flushing: boolean;
|
||
}
|
||
|
||
// ===== 服务类 =====
|
||
|
||
export class SessionRecorder {
|
||
/** P1-6: 每会话独立状态(支持并发会话录制) */
|
||
private sessions = new Map<string, SessionRecordState>();
|
||
|
||
/**
|
||
* F-8 接通: 录制总开关(logging.traceEnabled,默认 true)
|
||
* 关闭时 writeEvent 丢弃所有事件(状态 Map 仍维护以保持接口兼容)
|
||
*/
|
||
private enabled = true;
|
||
|
||
constructor(private workspacePath: string) {}
|
||
|
||
/** F-8: 设置录制开关(main.ts 启动时按 logging.traceEnabled 注入) */
|
||
setEnabled(enabled: boolean): void {
|
||
this.enabled = enabled;
|
||
if (!enabled) {
|
||
log.info('[SessionRecorder] Trace recording disabled by config (logging.traceEnabled=false)');
|
||
}
|
||
}
|
||
|
||
/** 获取指定会话的录制状态(不存在返回 null) */
|
||
private state(sessionId: string): SessionRecordState | null {
|
||
return this.sessions.get(sessionId) ?? null;
|
||
}
|
||
|
||
/**
|
||
* 开始录制会话
|
||
*/
|
||
startRecording(sessionId: string): void {
|
||
const logsDir = join(this.workspacePath, 'logs');
|
||
if (!existsSync(logsDir)) {
|
||
mkdirSync(logsDir, { recursive: true });
|
||
}
|
||
|
||
const timestamp = new Date().toISOString().replace(/[:.]/g, '-').slice(0, 19);
|
||
const filePath = join(logsDir, `session_${sessionId}_${timestamp}.jsonl`);
|
||
|
||
this.sessions.set(sessionId, {
|
||
filePath,
|
||
seq: 0,
|
||
buffer: [],
|
||
flushTimer: null,
|
||
flushing: false,
|
||
});
|
||
|
||
// 写入 session_start 事件
|
||
this.writeEvent(sessionId, {
|
||
event: 'session_start',
|
||
sessionId,
|
||
workspace: this.workspacePath,
|
||
});
|
||
|
||
log.info(`Session recording started: ${filePath}`);
|
||
}
|
||
|
||
/**
|
||
* 停止录制(P1-6: 按会话停止,不影响其他并发录制)
|
||
*/
|
||
stopRecording(
|
||
sessionId: string,
|
||
params: {
|
||
totalIterations: number;
|
||
totalTokens: number;
|
||
durationMs: number;
|
||
terminationReason: string;
|
||
},
|
||
): void {
|
||
const state = this.state(sessionId);
|
||
if (!state) return;
|
||
|
||
this.writeEvent(sessionId, {
|
||
event: 'session_end',
|
||
sessionId,
|
||
totalIterations: params.totalIterations,
|
||
totalTokens: params.totalTokens,
|
||
durationMs: params.durationMs,
|
||
terminationReason: params.terminationReason,
|
||
});
|
||
|
||
// #35 修复: 同步 flush 确保最后的 session_end 事件写入文件
|
||
this.flushSync(sessionId);
|
||
|
||
log.info(`Session recording stopped: ${state.filePath}`);
|
||
this.sessions.delete(sessionId);
|
||
}
|
||
|
||
/**
|
||
* 记录上下文构建
|
||
*/
|
||
recordContextBuilt(sessionId: string, params: { tokenCount: number; usageRatio: number }): void {
|
||
this.writeEvent(sessionId, {
|
||
event: 'context_built',
|
||
sessionId,
|
||
tokens: params.tokenCount,
|
||
ratio: params.usageRatio,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录迭代开始
|
||
*/
|
||
recordIterationStart(sessionId: string, iteration: number): void {
|
||
this.writeEvent(sessionId, {
|
||
event: 'iteration_start',
|
||
sessionId,
|
||
iteration,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录 LLM 请求
|
||
*/
|
||
recordLLMRequest(params: {
|
||
sessionId: string;
|
||
iteration: number;
|
||
provider: string;
|
||
model: string;
|
||
messageCount: number;
|
||
}): void {
|
||
this.writeEvent(params.sessionId, {
|
||
event: 'llm_request',
|
||
sessionId: params.sessionId,
|
||
iteration: params.iteration,
|
||
provider: params.provider,
|
||
model: params.model,
|
||
messageCount: params.messageCount,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录 LLM 响应
|
||
*/
|
||
recordLLMResponse(params: {
|
||
sessionId: string;
|
||
iteration: number;
|
||
content: string;
|
||
finishReason: string;
|
||
tokenUsage: { input: number; output: number; total: number };
|
||
}): void {
|
||
this.writeEvent(params.sessionId, {
|
||
event: 'llm_response',
|
||
sessionId: params.sessionId,
|
||
iteration: params.iteration,
|
||
contentPreview: params.content.slice(0, 200),
|
||
finishReason: params.finishReason,
|
||
tokenUsage: params.tokenUsage,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录工具调用
|
||
*/
|
||
recordToolCall(params: {
|
||
sessionId: string;
|
||
iteration: number;
|
||
toolName: string;
|
||
args: Record<string, unknown>;
|
||
}): void {
|
||
this.writeEvent(params.sessionId, {
|
||
event: 'tool_call',
|
||
sessionId: params.sessionId,
|
||
iteration: params.iteration,
|
||
tool: params.toolName,
|
||
args: params.args,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录工具结果
|
||
*/
|
||
recordToolResult(params: {
|
||
sessionId: string;
|
||
iteration: number;
|
||
toolName: string;
|
||
success: boolean;
|
||
durationMs: number;
|
||
resultPreview?: string;
|
||
error?: string;
|
||
}): void {
|
||
this.writeEvent(params.sessionId, {
|
||
event: 'tool_result',
|
||
sessionId: params.sessionId,
|
||
iteration: params.iteration,
|
||
tool: params.toolName,
|
||
success: params.success,
|
||
durationMs: params.durationMs,
|
||
resultPreview: params.resultPreview?.slice(0, 500),
|
||
error: params.error,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 记录迭代结束
|
||
*/
|
||
recordIterationEnd(sessionId: string, params: { iteration: number; durationMs: number }): void {
|
||
this.writeEvent(sessionId, {
|
||
event: 'iteration_end',
|
||
sessionId,
|
||
iteration: params.iteration,
|
||
durationMs: params.durationMs,
|
||
});
|
||
}
|
||
|
||
/**
|
||
* 获取录制文件路径
|
||
*/
|
||
getFilePath(sessionId?: string): string | null {
|
||
if (sessionId) return this.state(sessionId)?.filePath ?? null;
|
||
const first = this.sessions.values().next().value;
|
||
return first?.filePath ?? null;
|
||
}
|
||
|
||
// ===== 私有方法 =====
|
||
|
||
/**
|
||
* 写入事件到缓冲区
|
||
*
|
||
* #35 修复: 缓冲写入,定时异步 flush,避免每次 appendFileSync 阻塞主进程
|
||
* 高频事件(30-50 次/秒)先 push 到内存 buffer,每 100ms 批量异步写入文件
|
||
*/
|
||
private writeEvent(sessionId: string, data: Record<string, unknown>): void {
|
||
const state = this.state(sessionId);
|
||
if (!state) return;
|
||
// F-8 接通: logging.traceEnabled=false 时丢弃事件(不写文件)
|
||
if (!this.enabled) return;
|
||
|
||
const event: TraceEvent = {
|
||
seq: state.seq++,
|
||
ts: new Date().toISOString(),
|
||
sessionId,
|
||
...data,
|
||
} as TraceEvent;
|
||
|
||
const line = JSON.stringify(event);
|
||
|
||
// 审查修复: buffer 上限防止 OOM — 高频事件持续 flush 失败时避免内存无限增长
|
||
const MAX_BUFFER_SIZE = 1000;
|
||
if (state.buffer.length >= MAX_BUFFER_SIZE) {
|
||
// 超限时强制同步写入,避免内存无限增长
|
||
this.flushSync(sessionId);
|
||
}
|
||
state.buffer.push(line);
|
||
if (!state.flushTimer) {
|
||
state.flushTimer = setTimeout(() => {
|
||
const st = this.state(sessionId);
|
||
if (st) {
|
||
st.flushTimer = null;
|
||
void this.flush(sessionId);
|
||
}
|
||
}, 100);
|
||
}
|
||
}
|
||
|
||
/**
|
||
* #35 修复: 异步 flush 缓冲区到文件
|
||
* 审查修复: 用局部变量保存 filePath,防止 stopRecording 将状态删除后 appendFile 抛错;
|
||
* 失败时将数据 unshift 回 buffer 避免丢整批数据
|
||
*/
|
||
private async flush(sessionId: string): Promise<void> {
|
||
const state = this.state(sessionId);
|
||
if (!state || state.flushing || state.buffer.length === 0) return;
|
||
state.flushing = true;
|
||
const filePath = state.filePath; // 局部变量,防止中途状态被删除
|
||
const data = state.buffer.join('\n') + '\n';
|
||
state.buffer = [];
|
||
try {
|
||
await promises.appendFile(filePath, data, 'utf-8');
|
||
} catch (error) {
|
||
log.error('Trace event flush failed:', error);
|
||
// 审查修复: 失败时将数据放回 buffer 头部,下次 flush/flushSync 重试
|
||
const st = this.state(sessionId);
|
||
if (st) st.buffer.unshift(data.trimEnd());
|
||
} finally {
|
||
const st = this.state(sessionId);
|
||
if (st) st.flushing = false;
|
||
}
|
||
}
|
||
|
||
/**
|
||
* #35 修复: 同步 flush 缓冲区到文件
|
||
* 用于 stopRecording 确保最后的数据(如 session_end 事件)写入文件
|
||
* 审查修复: 如果异步 flush 正在进行(flushing=true),等待其完成后再写入,避免数据交叉/丢失
|
||
*/
|
||
private flushSync(sessionId: string): void {
|
||
const state = this.state(sessionId);
|
||
if (!state) return;
|
||
if (state.flushTimer) {
|
||
clearTimeout(state.flushTimer);
|
||
state.flushTimer = null;
|
||
}
|
||
if (state.buffer.length === 0) return;
|
||
const data = state.buffer.join('\n') + '\n';
|
||
state.buffer = [];
|
||
try {
|
||
appendFileSync(state.filePath, data, 'utf-8');
|
||
} catch (error) {
|
||
log.error('Trace event flushSync failed:', error);
|
||
// 审查修复: 失败时将数据放回 buffer,避免数据丢失
|
||
state.buffer.unshift(data.trimEnd());
|
||
}
|
||
}
|
||
}
|