P1 修复面收口: - 超时三态区分(aborted→USER_INTERRUPT / ETIMEDOUT→TIMEOUT / 其余→ERROR), 根治"真实网络超时被误报为用户中断" - 流空闲超时统一(SSE/Ollama/Anthropic 读循环 60s 无数据抛 504 进重试通道) - 同会话并发 sendMessage 防重入(isRunning 守卫)+ 会话存在性预检 + 前置调用移入 try(ERROR+DONE 双事件保证,根治 isStreaming 假死) - 清空审计后 resetChainCache(根治 verifyChain 误报 TAMPERED) - DONE 不再提前清理 TRACE(TERMINATED 统一收尾,补全最终迭代录制) - IME 合成回车不发送(普通 Enter + Cmd/Ctrl+Enter 双分支)+ handleSend 闭包修复 P2 安全纵深: - preload 移除原始 electronAPI 暴露(渲染层零使用,关掉 XSS invoke 任意通道单点风险) - CORS 同源回显根治(仅当前浏览页面 Origin,did-navigate 同步) - MEMORY.md 命令保护正则扩展(括号/$/反引号/< 重定向边界 + 前导路径) - write_file append TOCTOU 统一(open 后 realpath 校验,新文件分支补漏) - 敏感键归一化(authKey 驼峰/连字符命中)+ MCP headers 鉴权值加密落库 - ReDoS 检测共享化(search_files/file_editor 统一拦截) - run_tests/lint_code 升风险 + 需确认 + npx --no-install(执行边界对齐 run_command) - MCP/SearXNG/llm.baseURL/updateFeedUrl 配置类 URL 高危目标校验(IPv6 去括号 + 十六进制映射解析 + 尾点剥离) P3 架构还债: - temperature/maxTokens 热生效(引擎/编排器/SubAgent 三处接线)+ setBatch 单事务落盘 - SessionRecorder flush 竞态根治(flushPromise 等待 + 超限内联落盘 + stopRecording async) - 内存收口(lastConsolidationBySession LRU / subTraces 清理 / 会话删除 disposeEngine) - i18n 全量收口(28 组件 + 353 key 双字典,状态标签改渲染时函数) - 死代码清理(updateTraceStep/HEADER_HEIGHT/void preA/失实注释) - 斜杠菜单 MUI 化 + 删除逻辑收敛 resetSessionState + Blob URL 统一释放 + 用户消息"仅保存"落库(saveMessage 透传前端 id 修复 id 错位) P4 能力演进: - 死循环检测拆分(驻留前置 + 乒乓后置带进度信号,合法交替不误报) - run-lock 30s 超时强制 abort(旧 run 卡死不无限排队) - RETRY 双通道 stream_reset(前端按 run 归属精确清空,根治重试文本重复) - FTS5 trigram 中文子串搜索(迁移 9 版本化 SCHEMA_VERSION=2,≤2 字符 LIKE 回退) - getContextWindow 兜底 1M→128K(未知模型防 413) 测试: - 855 → 2406 用例(+1551,2.8 倍):服务层 +325(含 MemoryManager 51 新用例)、 工具实体 +483、IPC/适配器 +390(含 OpenAI/Anthropic/Ollama 独立套件)、 纯函数表格化 +330;引入 jsdom + @testing-library(14 组件测试文件 249 用例) - 修复 R1(saveMessage id 透传)/ R2(stream_reset 精确归属)两个回归缺陷 - 遗留低危项清零:git-tools 顺序耦合 / web-fetch 真实时间退避 / slo 内存断言 / mcp-security 多余 skipIf / deepseek-balance 命名误导 / 组件 mock 注入脆弱性 版本: 0.7.4; README 同步(工具风险表/版本徽章); 依赖: 移除 @electron-toolkit/preload, 新增 jsdom/@testing-library(devDependencies 不打包) 回归: typecheck 双端 0 错误; ESLint 0/0; Electron ABI 全量 2406/2406 零跳过; 系统 Node 2110 通过 296 跳过(better-sqlite3 ABI)
182 lines
7.7 KiB
TypeScript
182 lines
7.7 KiB
TypeScript
/**
|
||
* TitleGenerator 测试(v0.7.3 P4-1)
|
||
*
|
||
* T1 sanitizeTitle 清洗规则矩阵(围栏/引号/自述前缀/空白/截断/空值);
|
||
* T2 maybeGenerateTitle 幂等(每会话仅一次);
|
||
* T3 已有自定义标题的会话不覆盖;
|
||
* T4 LLM 失败/超时静默回退(不抛错,返回 null);
|
||
* T5 空输入门控。
|
||
*/
|
||
|
||
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
||
|
||
vi.mock('electron-log', () => ({
|
||
default: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() },
|
||
}));
|
||
|
||
import { TitleGenerator, sanitizeTitle } from '../title-generator.service';
|
||
import type { IMetonaProviderAdapter, MetonaResponse } from '../../harness/types';
|
||
|
||
describe('sanitizeTitle', () => {
|
||
it('T1a: 干净文本原样通过', () => {
|
||
expect(sanitizeTitle('修复登录超时')).toBe('修复登录超时');
|
||
});
|
||
|
||
it('T1b: markdown 围栏与列表标记剥离', () => {
|
||
expect(sanitizeTitle('```json\n"标题"\n```')).toBe('标题');
|
||
expect(sanitizeTitle('- 修复登录超时')).toBe('修复登录超时');
|
||
expect(sanitizeTitle('# 修复登录超时')).toBe('修复登录超时');
|
||
});
|
||
|
||
it('T1c: 成对包裹引号剥离', () => {
|
||
expect(sanitizeTitle('"修复登录超时"')).toBe('修复登录超时');
|
||
expect(sanitizeTitle('“修复登录超时”')).toBe('修复登录超时');
|
||
});
|
||
|
||
it('T1d: 自述前缀剥离(标题:/Title:)', () => {
|
||
expect(sanitizeTitle('标题: 修复登录超时')).toBe('修复登录超时');
|
||
expect(sanitizeTitle('Title: Fix login timeout')).toBe('Fix login timeout');
|
||
});
|
||
|
||
it('T1e: 换行折叠为空格、首尾空白去除', () => {
|
||
expect(sanitizeTitle('修复\n登录 超时\n')).toBe('修复 登录 超时');
|
||
});
|
||
|
||
it('T1f: 超长截断到 maxLen', () => {
|
||
const out = sanitizeTitle('a'.repeat(100), 40);
|
||
expect(out?.length).toBe(40);
|
||
});
|
||
|
||
it('T1g: 空值/纯符号 → null', () => {
|
||
expect(sanitizeTitle('')).toBeNull();
|
||
expect(sanitizeTitle(' ')).toBeNull();
|
||
expect(sanitizeTitle('"""')).toBeNull();
|
||
expect(sanitizeTitle('###')).toBeNull();
|
||
});
|
||
});
|
||
|
||
function makeAdapter(content: string | Error): IMetonaProviderAdapter {
|
||
return {
|
||
providerId: 'mock',
|
||
supportedModels: ['m'],
|
||
supportsToolCalling: true,
|
||
supportsThinking: false,
|
||
getContextWindow: () => 128_000,
|
||
send: vi.fn(async (): Promise<MetonaResponse> => {
|
||
if (content instanceof Error) throw content;
|
||
return {
|
||
meta: { requestId: 'r', provider: 'mock', model: 'm', latencyMs: 1, timestamp: Date.now() },
|
||
content,
|
||
usage: { inputTokens: 1, outputTokens: 1, totalTokens: 2 },
|
||
finishReason: 'stop' as never,
|
||
};
|
||
}),
|
||
sendStream: vi.fn(),
|
||
setAbortSignal: vi.fn(),
|
||
healthCheck: async () => true,
|
||
} as unknown as IMetonaProviderAdapter;
|
||
}
|
||
|
||
function makeSessionService(existing: Array<{ id: string; title: string }> = []) {
|
||
// 注意:真实 SessionService.list()/getSession() 是同步方法(better-sqlite3),
|
||
// mock 必须保持同步返回,否则 generate 内的 .find() 拿到 Promise
|
||
return {
|
||
list: vi.fn(() => existing) as unknown as () => Array<{ id: string; title: string }>,
|
||
// v0.7.4: TitleGenerator 改用 getSession(含归档会话)判断已有标题
|
||
getSession: vi.fn((id: string) => existing.find((s) => s.id === id) ?? null),
|
||
rename: vi.fn(() => true),
|
||
};
|
||
}
|
||
|
||
describe('TitleGenerator.maybeGenerateTitle', () => {
|
||
beforeEach(() => {
|
||
vi.useFakeTimers();
|
||
});
|
||
afterEach(() => {
|
||
vi.useRealTimers();
|
||
});
|
||
|
||
it('T2: 首个 run 生成标题并调用 rename;同会话幂等', async () => {
|
||
const svc = makeSessionService([{ id: 's1', title: '新会话' }]);
|
||
const gen = new TitleGenerator(() => makeAdapter('修复登录超时'), svc as never);
|
||
const title = await gen.maybeGenerateTitle(
|
||
's1',
|
||
'帮我看看为什么登录会超时',
|
||
'已定位为 token 过期…',
|
||
);
|
||
expect(title).toBe('修复登录超时');
|
||
expect(svc.rename).toHaveBeenCalledWith('s1', '修复登录超时');
|
||
|
||
// 第二次调用(同会话)幂等 —— 不再调用 LLM
|
||
const second = await gen.maybeGenerateTitle('s1', '再问一次', '再答一次');
|
||
expect(second).toBeNull();
|
||
});
|
||
|
||
it('T3: 已有自定义标题的会话不覆盖', async () => {
|
||
const svc = makeSessionService([{ id: 's1', title: '用户手动命名' }]);
|
||
const adapterSend = vi.fn();
|
||
const adapter = makeAdapter('不应被使用');
|
||
(adapter.send as ReturnType<typeof vi.fn>).mockImplementation(async (...args: unknown[]) => {
|
||
adapterSend(...args);
|
||
throw new Error('should not be called');
|
||
});
|
||
const gen = new TitleGenerator(() => adapter, svc as never);
|
||
const title = await gen.maybeGenerateTitle('s1', '内容', '回答');
|
||
expect(title).toBeNull();
|
||
expect(adapterSend).not.toHaveBeenCalled();
|
||
});
|
||
|
||
// v0.7.4 修复: 前端自动截断标题(首条消息前 30 字符)不是"自定义标题",
|
||
// 应被 LLM 标题覆盖 —— 旧实现把截断标题误判为自定义标题,LLM 标题永不生成
|
||
it('T3b: 前端自动截断标题仍生成 LLM 标题覆盖(v0.7.4 根因修复)', async () => {
|
||
// 长消息(>30 字符)→ 前端自动标题 = 前 30 字符 + '...'
|
||
const userMsg = '帮我看看为什么登录总是超时而且偶尔还会直接崩溃然后闪退重试也不行';
|
||
const autoTitle = userMsg.slice(0, 30) + '...';
|
||
const svc = makeSessionService([{ id: 's1', title: autoTitle }]);
|
||
const gen = new TitleGenerator(() => makeAdapter('修复登录超时'), svc as never);
|
||
const title = await gen.maybeGenerateTitle('s1', userMsg, '已定位为 token 过期…');
|
||
expect(title).toBe('修复登录超时');
|
||
expect(svc.rename).toHaveBeenCalledWith('s1', '修复登录超时');
|
||
});
|
||
|
||
it('T3c: 短消息(≤30 字符)的自动截断标题(=原文)仍生成 LLM 标题覆盖', async () => {
|
||
const userMsg = '解释一下事件循环';
|
||
const svc = makeSessionService([{ id: 's2', title: userMsg }]);
|
||
const gen = new TitleGenerator(() => makeAdapter('事件循环机制'), svc as never);
|
||
const title = await gen.maybeGenerateTitle('s2', userMsg, '事件循环是…');
|
||
expect(title).toBe('事件循环机制');
|
||
expect(svc.rename).toHaveBeenCalledWith('s2', '事件循环机制');
|
||
});
|
||
|
||
it('T4: LLM 失败静默回退(返回 null,不抛错),且同会话不重试', async () => {
|
||
const svc = makeSessionService([{ id: 's1', title: '新会话' }]);
|
||
const gen = new TitleGenerator(() => makeAdapter(new Error('network down')), svc as never);
|
||
await expect(gen.maybeGenerateTitle('s1', 'q', 'a')).resolves.toBeNull();
|
||
await expect(gen.maybeGenerateTitle('s1', 'q2', 'a2')).resolves.toBeNull();
|
||
expect(svc.rename).not.toHaveBeenCalled();
|
||
});
|
||
|
||
it('T5: 空 sessionId / 双向空内容 → 不生成', async () => {
|
||
const svc = makeSessionService();
|
||
const adapter = makeAdapter('x');
|
||
const gen = new TitleGenerator(() => adapter, svc as never);
|
||
expect(await gen.maybeGenerateTitle('', 'q', 'a')).toBeNull();
|
||
expect(await gen.maybeGenerateTitle('s1', ' ', ' ')).toBeNull();
|
||
});
|
||
|
||
it('T6: 并发重入复用同一 Promise(不重复调用 LLM)', async () => {
|
||
const svc = makeSessionService([{ id: 's1', title: '新会话' }]);
|
||
const gen = new TitleGenerator(() => makeAdapter('并发标题'), svc as never);
|
||
// 使用真实定时器场景下并发触发
|
||
vi.useRealTimers();
|
||
const [a, b] = await Promise.all([
|
||
gen.maybeGenerateTitle('s2', 'q', 'a'),
|
||
gen.maybeGenerateTitle('s2', 'q', 'a'),
|
||
]);
|
||
expect(a).toBe('并发标题');
|
||
expect(b).toBe('并发标题');
|
||
// rename 仅一次(并发重入复用)
|
||
expect(svc.rename).toHaveBeenCalledTimes(1);
|
||
});
|
||
});
|