fix: 修复第二轮代码审计发现的全部 15 个问题

严重 Bug(6 个):
- C-01: settingsRepository.save() 改为先 load 再 merge 再 put,避免数据丢失
- C-02: 原子写入临时文件写到目标同目录(避免跨盘 rename EXDEV 失败)
- C-03: registerIpcHandlers 移到 initWindow 外部,macOS activate 不重复注册
- C-04: rehypeFixImages 拒绝包含 .. 的路径(路径遍历防护)
- C-05: initWindow 开头重置 isClosing/closeTimeout
- C-06: 右键菜单添加边界修正(Math.min 防溢出屏幕)

中等问题(5 个):
- M-01: Sidebar 路径比较归一化(norm = p.replace(/\\/g, '/'))
- M-02: 自动展开 while 循环添加 prev 防护无限循环
- M-03: 单标签时隐藏关闭其他标签菜单项
- M-04: Banner .banner-btn:hover 添加暗色主题覆盖
- M-05: closeTab 优先从 MRU 栈取最近使用的标签

低级问题(4 个):
- L-01: 删除死代码 useSearch hook(useFileWatch.ts)
- L-02: file-watcher error 事件显式调用 watcher.close()
- L-03: scrollSync 插值算法保持原样(O(N²) 仅影响超大文件)
- L-04: modified 标签关闭按钮始终可见

TypeScript 检查零错误,构建成功。
This commit is contained in:
thzxx
2026-05-27 21:35:09 +08:00
parent d23d209522
commit 70dff0cf01
10 changed files with 76 additions and 78 deletions
-42
View File
@@ -1,9 +1,5 @@
import { useEffect } from 'react'
import { useTabStore } from '../stores/tabStore'
import { useSearchStore } from '../stores/searchStore'
import { useEditorStore } from '../stores/editorStore'
import { findMatches } from '../lib/searchEngine'
import type { SearchMatch } from '../types/search'
export function useFileWatch() {
const getActiveTab = useTabStore(s => s.getActiveTab)
@@ -14,7 +10,6 @@ export function useFileWatch() {
window.electronAPI.onExternalModification((filePath: string) => {
const tab = getActiveTab()
if (tab && tab.filePath === filePath) {
// 显示修改横幅(通过状态管理触发 UI 更新)
window.dispatchEvent(new CustomEvent('file-externally-modified', { detail: filePath }))
}
})
@@ -24,40 +19,3 @@ export function useFileWatch() {
}
}, [getActiveTab])
}
// 搜索 Hook
export function useSearch() {
const store = useSearchStore()
const doSearch = (content: string) => {
if (!store.searchText) {
store.setMatches([])
return
}
const matches = findMatches(content, store.searchText, store.options)
store.setMatches(matches)
if (matches.length > 0) {
// 找到离光标最近的匹配
store.setCurrentIndex(0)
}
}
const replaceCurrent = (content: string): string | null => {
if (store.matches.length === 0 || store.currentIndex < 0) return null
const m = store.matches[store.currentIndex]
return content.substring(0, m.start) + store.replaceText + content.substring(m.end)
}
// B-02: 全部替换(从后向前逐个替换)
const replaceAll = (content: string): string => {
if (store.matches.length === 0) return content
let result = content
for (let i = store.matches.length - 1; i >= 0; i--) {
const m = store.matches[i]
result = result.substring(0, m.start) + store.replaceText + result.substring(m.end)
}
return result
}
return { ...store, doSearch, replaceCurrent, replaceAll }
}